https://bugzilla.redhat.com/show_bug.cgi?id=2239462 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xavier@xxxxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Xavier Bachelot <xavier@xxxxxxxxxxxx> --- Hi Charles, Drive-by review, sorry if it's a bit terse: - Use cpan.metacpan.org as the Source0 URL - Drop __perl macro in favor of straight perl - Add NO_PACKLIST=1 NO_PERLLOCAL=1 to 'perl MakeFile.PL ...' and drop the 2 find's in %install - 'make pure_install ...' can be replaced by %make_install - You can use %make_build in %check - The wildcards are too wide in %files, be more specific Regards, Xavier -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2239462 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202239462%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
