https://bugzilla.redhat.com/show_bug.cgi?id=2239558 --- Comment #3 from Troy Dawson <tdawson@xxxxxxxxxx> --- Looks very nice. There are only two issues. License: Although the main package source is correct, it is all LGPL-2.0-or-later, there are a couple side packages that have different licenses. Do the following to get the full list. grep -h -r SPDX-License-Identifier | sort -u I'm still new to the SPDX notation, but I think this is what is should be License: LGPL-2.1-or-later AND GPL-2.0-or-later AND CC0-1.0 Files Listed Multiple Times: In your files section you have the following lines %{_kf6_datadir}/qlogging-categories6/*categories %{_kf6_datadir}/qlogging-categories6/*.categories I think you just want the first one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2239558 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202239558%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
