[Bug 2239563] Review Request: kf6-syntax-highlighting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2239563



--- Comment #3 from Troy Dawson <tdawson@xxxxxxxxxx> ---
%description is in the wrong place.
Because you have it before the BuildRequires and Requires, rpmbuild is thinking
all those BuildRequires are part of the descriptions and does not pull them in.

Even then, it is still failing builds with missing files. 
File not found:
/builddir/build/BUILDROOT/kf6-syntax-highlighting-5.240.0^20230917.220810.80b312632182971f3480e147aa2c9d0ad9d73035-123.fc40.x86_64/usr/lib64/libKF6SyntaxHighlighting.so.5.240

It looks like the file ends up at
/usr/lib64/libKF6SyntaxHighlighting.so.5.240.0

Here is a diff with both of those fixes in them.  With these, it builds on
Fedora Rawhide mock.

--- kf6-syntax-highlighting.spec        2023-09-25 08:32:24.164759164 -0700
+++ kf6-syntax-highlighting.spec.original       2023-09-25 08:31:53.540409091
-0700
@@ -12,6 +12,9 @@
 URL:            https://invent.kde.org/frameworks/%{framework}
 Source0:       
https://invent.kde.org/frameworks/%{framework}/-/archive/%{commit0}/%{framework}-%{commit0}.tar.gz

+%description
+%{summary}.
+
 # KDE Frameworks
 BuildRequires:  extra-cmake-modules

@@ -26,9 +29,6 @@
 BuildRequires:  cmake(Qt6Core)
 BuildRequires:  cmake(Qt6Qml)

-%description
-%{summary}.
-
 %package        devel
 Summary:        Development files for %{name}
 Requires:       %{name}%{?_isa} = %{version}-%{release}
@@ -56,7 +56,7 @@
 %license LICENSES/*.txt
 %{_kf6_bindir}/ksyntaxhighlighter6
 %{_kf6_datadir}/qlogging-categories6/*categories
-%{_kf6_libdir}/libKF6SyntaxHighlighting.so.5.240.0
+%{_kf6_libdir}/libKF6SyntaxHighlighting.so.5.240
 %{_kf6_libdir}/libKF6SyntaxHighlighting.so.6
 %{_kf6_qmldir}/org/kde/syntaxhighlighting


Note:  This isn't a review, this is just helping to get the package build-able.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2239563

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202239563%23c3
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux