https://bugzilla.redhat.com/show_bug.cgi?id=2122160 --- Comment #5 from Jens Petersen <petersen@xxxxxxxxxx> --- Thank you for reviewing (In reply to Tristan Cacqueray from comment #4) > - Shouldn't the license be BSD-3-Clause? Yes, sorry should have updated > - Not sure what is the process to restore previously unmaintained package, > will the fedora-review + flag process skip the creation? Right the package will have to be unretired once this package review is approved. > - Example code in the -devel package are installed in /usr/share, > shouldn't they be part of the doc package? Good catch Given the total size I wonder if it makes not sense just to remove them? hmmm > - I think the undefined-non-weak-symbol and unused-direct-shlib-dependency > are caused by https://gitlab.haskell.org/ghc/ghc/-/issues/17157 > - Not sure about the debuginfo stuff, I guess that's expected for haskell > libraries? Yes, I thought so > ===== MUST items ===== > > C/C++: > [?]: Provides: bundled(gnulib) in place as required. > Note: Sources not installed Not sure where that comes from > [?]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ghc- > GLUT-prof Well it is indirect though the devel package (prof -> devel -> base), but yeah it is flagged, so perhaps I should enforce it in ghc-rpm-macros... > Generic: > [!]: Large data in /usr/share should live in a noarch subpackage if package > is arched. > Note: Arch-ed rpms have a total of 1259520 bytes in /usr/share -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2122160 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202122160%23c5 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
