https://bugzilla.redhat.com/show_bug.cgi?id=2237768 --- Comment #2 from Robert Scheck <redhat-bugzilla@xxxxxxxxxxxx> --- Some first thoughts while reading the spec file: > Requires: golly-data Is it really intended that this requirement is unversioned? If not, I would recommend "golly-data = %{version}-%{release}" instead. Why is the golly-devel subpackage not noarch, too? It seems to populate the same paths like golly-data does. If golly-devel contains versioned content, I recommend to switch from "%{name} = %{version}-%{release}" to "%{name}%{?_isa} = %{version}-%{release}". And if it's unversioned, I think "BuildArch: noarch" would make more sense. Is it intended that only golly-data can be installed (without having golly itself installed)? Depending on how strong the dependency is (just a wild guess), it also could be e.g. "Recommends: golly-data" in the main package and "Requires: golly" in the subpackage. > desktop-file-validate %{buildroot}%{_datadir}/applications/%{name}.desktop I would recommend to move this into %check, https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage (it seems to be more a check rather than an installation command). > URL: http://golly.sourceforge.net/ You could switch the URI scheme to HTTPS. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2237768 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202237768%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
