Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Package review: vixie-cron-ng https://bugzilla.redhat.com/show_bug.cgi?id=428007 nphilipp@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |needinfo?(mmaslano@xxxxxxxxx | |m) ------- Additional Comments From nphilipp@xxxxxxxxxx 2008-01-10 11:24 EST ------- CHECK: - pkg name possibly in conflict with 3rd clause of BSD license (no promotion or endorsement with contributor names) -- search for alternative name is in progress - rpmlint checks return: vixie-cron-ng.src:17: W: unversioned-explicit-provides vixie-cron --> Possibly change that to "Provides: vixie-cron = 4:4.3" (or whatever else vixie-cron version this package replaces, just be sure to list the epoch as well) vixie-cron-ng.src: W: mixed-use-of-spaces-and-tabs (spaces: line 80, tab: line 92) --> use either spaces or tabs consistently for indentation, not both - license text not in %doc, possibly add AUTHORS, CHANGES, README as well - source matches upstream, but the URL is incorrect. Because the tarball is attached to a Trac wiki page, "?format=raw" is needed to actually download the tarball. Perhaps add a comment with points to the real URL (as changing the "Source: ..." line won't work with koji, it can't handle CGI parameters) - possibly unnecessary "BR: automake", you don't use it anywhere in the spec file - macro use inconsistent: use '%{_initrddir}' instead of '%{_sysconfdir}/rc.d/init.d' in the spec file - what purpose does "make ... RPM_OPT_FLAGS="$RPM_OPT_FLAGS -DLINT -Dlint" have? - %postun mustn't fail (append " || :" like in %preun) - "make install" does much too few which you workaround in the spec file by creating directories, copying/moving stuff to the directories, I can help with automake/autofoo if you wish so "make install" just works (possibly followup issues of the last one: - no need to use %attr() for all the files if "make install" just does "the right thing" - don't move files out of the source/build directory as it breaks "rpm -bi --short-circuit", just copy them, or better let them be installed with "make install" - instead of renaming %{_sysconfdir}/pam.d/crond.pam to .../crond, just let "make install" do the right thing (i.e. install the file as "crond", not "crond.pam") ) GOOD: - package meets Fedora naming guidelines - license (BSD and MIT) OK, matches source - spec file legible, in am. english - package compiles on devel (x86_64) - no missing BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review