https://bugzilla.redhat.com/show_bug.cgi?id=2235088 --- Comment #6 from Kalev Lember <klember@xxxxxxxxxx> --- Indeed, and I apparently even had updated locally, but forgot to update the review request: Spec URL: https://kalev.fedorapeople.org/rust-libheif-rs.spec SRPM URL: https://kalev.fedorapeople.org/rust-libheif-rs-0.21.0-1.fc40.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=106439272 There's even newer, 0.22.0 release available from upstream now, but that requires rust-libheif-sys update first, so I've left it out for now to simplify things. Either version should be fine for glycin-loaders. One thing I am unsure about is how to handle the test data licensing and if we should reflect it in the license tag. Upstream cleaned the test data up nicely and it's all under CC-BY-SA-4.0 now, but didn't reflect the CC-BY-SA-4.0 addition in the crate license. My gut feeling is that this is the right thing to do, because whatever we put in the license field gets included in the license field of the packages that consume the rust crate (e.g. glycin-loaders), and they don't use the test data (and CC-BY-SA-4.0 license) at all. Maybe an option would be to exclude the test data in %files list? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2235088 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202235088%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
