https://bugzilla.redhat.com/show_bug.cgi?id=2239662 Pavel Solovev <daron439@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |daron439@xxxxxxxxx --- Comment #2 from Pavel Solovev <daron439@xxxxxxxxx> --- please provide direct links to spec and srpm so that they are picked by the fedora-review tool correctly (eg. https://raw.githubusercontent.com/katalix/go-l2tp-fedora/master/golang-github-katalix-l2tp.spec) BuildRequires: ... aren't needed, handeled by %go_generate_buildrequires manpages are installed in %{_mandir}/man1 %{_mandir}/man5, executable bit isn't needed Packagers SHOULD NOT simply glob everything under a shared directory https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists --- /proc/self/fd/14 2023-09-20 13:33:13.080116090 +0300 +++ golang-github-katalix-l2tp.spec 2023-09-20 13:32:37.091307757 +0300 @@ -21,14 +21,6 @@ URL: %{gourl} Source: %{gosource} -BuildRequires: golang(github.com/go-kit/kit/log) -BuildRequires: golang(github.com/go-kit/kit/log/level) -BuildRequires: golang(github.com/mdlayher/genetlink) -BuildRequires: golang(github.com/mdlayher/netlink) -BuildRequires: golang(github.com/mdlayher/netlink/nlenc) -BuildRequires: golang(github.com/pelletier/go-toml) -BuildRequires: golang(golang.org/x/sys/unix) - %description %{common_description} %gopkg @@ -49,13 +41,13 @@ %gopkginstall install -m 0755 -vd %{buildroot}%{_bindir} install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/ -install -m 0755 -vd %{buildroot}%{_mandir}/1 -install -m 0755 -vp %{_builddir}/go-l2tp-%{version}/doc/kl2tpd.1 %{buildroot}%{_mandir}/1 -install -m 0755 -vp %{_builddir}/go-l2tp-%{version}/doc/kpppoed.1 %{buildroot}%{_mandir}/1 -install -m 0755 -vp %{_builddir}/go-l2tp-%{version}/doc/ql2tpd.1 %{buildroot}%{_mandir}/1 -install -m 0755 -vd %{buildroot}%{_mandir}/5 -install -m 0755 -vp %{_builddir}/go-l2tp-%{version}/doc/kl2tpd.toml.5 %{buildroot}%{_mandir}/5 -install -m 0755 -vp %{_builddir}/go-l2tp-%{version}/doc/ql2tpd.toml.5 %{buildroot}%{_mandir}/5 +install -m 0755 -vd %{buildroot}%{_mandir}/man1 +install -m 0644 -vp %{_builddir}/go-l2tp-%{version}/doc/kl2tpd.1 %{buildroot}%{_mandir}/man1 +install -m 0644 -vp %{_builddir}/go-l2tp-%{version}/doc/kpppoed.1 %{buildroot}%{_mandir}/man1 +install -m 0644 -vp %{_builddir}/go-l2tp-%{version}/doc/ql2tpd.1 %{buildroot}%{_mandir}/man1 +install -m 0755 -vd %{buildroot}%{_mandir}/man5 +install -m 0644 -vp %{_builddir}/go-l2tp-%{version}/doc/kl2tpd.toml.5 %{buildroot}%{_mandir}/man5 +install -m 0644 -vp %{_builddir}/go-l2tp-%{version}/doc/ql2tpd.toml.5 %{buildroot}%{_mandir}/man5 %if %{with check} %check @@ -65,8 +57,10 @@ %files %license LICENSE %doc CHANGELOG.md README.md -%{_bindir}/* -%{_mandir}/*/* +%{_bindir}/kl2tpd +%{_bindir}/kpppoed +%{_bindir}/ql2tpd +%{_mandir}/man{1,5}/*.{1,5}* %gopkgfiles -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2239662 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202239662%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
