https://bugzilla.redhat.com/show_bug.cgi?id=2232203 --- Comment #5 from Kevin Fenzi <kevin@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= Here's what fedora review came up with: - Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. Note: Unversionned Python dependency found. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Python/#_dependencies I think this is a false positive because the requires is: python3-receptor-python-worker which has 'python' in it. ;) - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file license.go is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text This seems to be because of: ./Source1/vendor/k8s.io/kube-openapi/pkg/validation/spec/license.go It's the license for the api...I suppose this should be added to %golicense? - systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in receptor See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_scriptlets There are systemd files shipped, so they should follow the guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/ Or does it not make sense to setup the main receptor service and it expects users to setup their own with the template service file? Things I noticed: - Please own /etc/receptor directory - Should we not ship the /etc/receptor/receptor.conf.sample if we are shipping it as /etc/receptor/receptor.conf? - Can different versions of the 3 packages all operate ok? If not, it might be safer to require the exact version on all of them. ie, Requires: %{name}%{?_isa} = %{version}-%{release}, instead of just requiring the name. - rpmlint says: receptor.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/receptor/docs/make.bat Could dos2unix it, or just ignore. receptor.x86_64: E: version-control-internal-file /usr/share/doc/receptor/tools/examples/simple-network/.gitignore receptor.x86_64: E: version-control-internal-file /usr/share/doc/receptor/tools/examples/simple-network/socks/.gitignore Might exclude these? receptor.x86_64: W: unused-direct-shlib-dependency /usr/bin/receptor /lib64/libresolv.so.2 Should this really be linked with -lresolv? receptor.x86_64: E: script-without-shebang /etc/receptor/receptor.conf receptor.x86_64: E: script-without-shebang /etc/receptor/receptor.conf.example Mode here should be 644 instead of 755? receptor.x86_64: W: non-standard-uid /etc/receptor/receptor.conf receptor receptor.x86_64: W: non-standard-uid /etc/receptor/receptor.conf.example receptor receptor.x86_64: W: non-standard-gid /etc/receptor/receptor.conf receptor receptor.x86_64: W: non-standard-gid /etc/receptor/receptor.conf.example receptor If you are going to use a receptor user/group, need to set those up: https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/ receptor.x86_64: E: non-readable /usr/share/selinux/packages/receptor.pp 600 Probibly should be 644? I mean, its open source, anyone can find it and look at it, right? receptor.x86_64: W: no-manual-page-for-binary receptor python3-receptor-python-worker.x86_64: W: no-manual-page-for-binary receptor-python-worker receptorctl.x86_64: W: no-manual-page-for-binary receptorctl Can be ignored. python3-receptor-python-worker.x86_64: E: no-binary receptorctl.x86_64: E: no-binary These likely can't be noarch since the main package they depend on is archfull, so this can be ignored. receptor.x86_64: E: executable-marked-as-config-file /etc/receptor/receptor.conf Will be fixed with mode 644 as above. ===== MUST items ===== [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "BSD 3-Clause License", "MIT License", "Apache License 2.0", "Apache License 2.0 and/or MIT License", "BSD 3-Clause License and/or MIT License", "ISC License", "BSD 2-Clause License", "*No copyright* MIT License", "OpenSSL License", "Apache License 2.0 [generated file]". 2085 files have unknown license. Detailed output of licensecheck in /home/kevin/fedora/reviews/2232203-receptor/review- receptor/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package requires other packages for directories it uses. Note: No known owner of /etc/receptor [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/selinux/packages, /etc/receptor, /usr/share/selinux [x]: %build honors applicable compiler flags or justifies otherwise. [-]: Package contains no bundled libraries without FPC exception. Note: Especially check following dirs for bundled code: /home/kevin/fedora/reviews/2232203-receptor/review-receptor/upstream- unpacked/Source1/vendor/k8s.io/utils/internal/third_party, /home/kevin/fedora/reviews/2232203-receptor/review-receptor/upstream- unpacked/Source1/vendor/k8s.io/kube-openapi/pkg/internal/third_party, /home/kevin/fedora/reviews/2232203-receptor/review-receptor/upstream- unpacked/Source1/vendor/k8s.io/apimachinery/third_party [-]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [-]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [!]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 202913 bytes in 34 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in receptorctl , python3-receptor-python-worker [-]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: receptor-1.4.1-1.fc40.x86_64.rpm receptorctl-1.4.1-1.fc40.x86_64.rpm python3-receptor-python-worker-1.4.1-1.fc40.x86_64.rpm receptor-debuginfo-1.4.1-1.fc40.x86_64.rpm receptor-debugsource-1.4.1-1.fc40.x86_64.rpm receptor-1.4.1-1.fc40.src.rpm =================================== rpmlint session starts =================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpczzag67q')] checks: 31, packages: 6 receptor.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/receptor/docs/make.bat receptor.x86_64: E: version-control-internal-file /usr/share/doc/receptor/tools/examples/simple-network/.gitignore receptor.x86_64: E: version-control-internal-file /usr/share/doc/receptor/tools/examples/simple-network/socks/.gitignore receptor.src: W: strange-permission receptor.spec 600 receptor.x86_64: E: script-without-shebang /etc/receptor/receptor.conf receptor.x86_64: E: script-without-shebang /etc/receptor/receptor.conf.example receptor.x86_64: W: non-standard-uid /etc/receptor/receptor.conf receptor receptor.x86_64: W: non-standard-uid /etc/receptor/receptor.conf.example receptor receptor.x86_64: W: non-standard-gid /etc/receptor/receptor.conf receptor receptor.x86_64: W: non-standard-gid /etc/receptor/receptor.conf.example receptor receptor.x86_64: E: non-readable /usr/share/selinux/packages/receptor.pp 600 python3-receptor-python-worker.x86_64: W: no-manual-page-for-binary receptor-python-worker receptor.x86_64: W: no-manual-page-for-binary receptor receptorctl.x86_64: W: no-manual-page-for-binary receptorctl python3-receptor-python-worker.x86_64: E: no-binary receptorctl.x86_64: E: no-binary receptor.spec:118: W: mixed-use-of-spaces-and-tabs (spaces: line 17, tab: line 118) receptor.spec: W: invalid-url Source1: vendor-1.4.1.tar.gz receptor.x86_64: E: executable-marked-as-config-file /etc/receptor/receptor.conf === 6 packages and 0 specfiles checked; 8 errors, 11 warnings, 8 badness; has taken 3.4 s ==== Rpmlint (debuginfo) ------------------- Checking: receptor-debuginfo-1.4.1-1.fc40.x86_64.rpm =================================== rpmlint session starts =================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp6jugmxhd')] checks: 31, packages: 1 ==== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.8 s ==== Rpmlint (installed packages) ---------------------------- /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 5 receptor.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/receptor/docs/make.bat receptor.x86_64: E: version-control-internal-file /usr/share/doc/receptor/tools/examples/simple-network/.gitignore receptor.x86_64: E: version-control-internal-file /usr/share/doc/receptor/tools/examples/simple-network/socks/.gitignore receptor.x86_64: W: unused-direct-shlib-dependency /usr/bin/receptor /lib64/libresolv.so.2 receptor.x86_64: E: script-without-shebang /etc/receptor/receptor.conf receptor.x86_64: E: script-without-shebang /etc/receptor/receptor.conf.example receptor.x86_64: W: non-standard-uid /etc/receptor/receptor.conf receptor receptor.x86_64: W: non-standard-uid /etc/receptor/receptor.conf.example receptor receptor.x86_64: W: non-standard-gid /etc/receptor/receptor.conf receptor receptor.x86_64: W: non-standard-gid /etc/receptor/receptor.conf.example receptor receptor.x86_64: E: non-readable /usr/share/selinux/packages/receptor.pp 600 receptor.x86_64: W: no-manual-page-for-binary receptor python3-receptor-python-worker.x86_64: W: no-manual-page-for-binary receptor-python-worker receptorctl.x86_64: W: no-manual-page-for-binary receptorctl python3-receptor-python-worker.x86_64: E: no-binary receptorctl.x86_64: E: no-binary receptor.x86_64: E: executable-marked-as-config-file /etc/receptor/receptor.conf 5 packages and 0 specfiles checked; 8 errors, 9 warnings, 8 badness; has taken 1.7 s Source checksums ---------------- https://github.com/ansible/receptor/archive/v1.4.1/receptor-1.4.1.tar.gz : CHECKSUM(SHA256) this package : 09e75c4ac49e291c35b938ddfcca6297c7b32c1f9693f9c68e87fd7b33c862d5 CHECKSUM(SHA256) upstream package : 09e75c4ac49e291c35b938ddfcca6297c7b32c1f9693f9c68e87fd7b33c862d5 Requires -------- receptor (rpmlib, GLIBC filtered): /bin/sh config(receptor) libc.so.6()(64bit) libresolv.so.2()(64bit) python3-receptor-python-worker receptorctl rtld(GNU_HASH) receptorctl (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3-receptor-python-worker python3.12dist(click) python3.12dist(python-dateutil) python3.12dist(pyyaml) receptor python3-receptor-python-worker (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) receptor-debuginfo (rpmlib, GLIBC filtered): receptor-debugsource (rpmlib, GLIBC filtered): Provides -------- receptor: bundled(golang(github.com/creack/pty)) bundled(golang(github.com/davecgh/go-spew)) bundled(golang(github.com/emicklei/go-restful/v3)) bundled(golang(github.com/fortytw2/leaktest)) bundled(golang(github.com/fsnotify/fsnotify)) bundled(golang(github.com/ghjm/cmdline)) bundled(golang(github.com/go-logr/logr)) bundled(golang(github.com/go-openapi/jsonpointer)) bundled(golang(github.com/go-openapi/jsonreference)) bundled(golang(github.com/go-openapi/swag)) bundled(golang(github.com/go-task/slim-sprig)) bundled(golang(github.com/gogo/protobuf)) bundled(golang(github.com/golang-jwt/jwt/v4)) bundled(golang(github.com/golang/mock)) bundled(golang(github.com/golang/protobuf)) bundled(golang(github.com/google/gnostic)) bundled(golang(github.com/google/go-cmp)) bundled(golang(github.com/google/gofuzz)) bundled(golang(github.com/google/pprof)) bundled(golang(github.com/google/shlex)) bundled(golang(github.com/google/uuid)) bundled(golang(github.com/gorilla/websocket)) bundled(golang(github.com/imdario/mergo)) bundled(golang(github.com/josharian/intern)) bundled(golang(github.com/json-iterator/go)) bundled(golang(github.com/jupp0r/go-priority-queue)) bundled(golang(github.com/mailru/easyjson)) bundled(golang(github.com/minio/highwayhash)) bundled(golang(github.com/moby/spdystream)) bundled(golang(github.com/modern-go/concurrent)) bundled(golang(github.com/modern-go/reflect2)) bundled(golang(github.com/munnerz/goautoneg)) bundled(golang(github.com/onsi/ginkgo/v2)) bundled(golang(github.com/pbnjay/memory)) bundled(golang(github.com/pmezard/go-difflib)) bundled(golang(github.com/prep/socketpair)) bundled(golang(github.com/quic-go/qtls-go1-20)) bundled(golang(github.com/quic-go/quic-go)) bundled(golang(github.com/rogpeppe/go-internal)) bundled(golang(github.com/songgao/water)) bundled(golang(github.com/spf13/pflag)) bundled(golang(github.com/stretchr/testify)) bundled(golang(github.com/vishvananda/netlink)) bundled(golang(github.com/vishvananda/netns)) bundled(golang(golang.org/x/crypto)) bundled(golang(golang.org/x/exp)) bundled(golang(golang.org/x/mod)) bundled(golang(golang.org/x/net)) bundled(golang(golang.org/x/oauth2)) bundled(golang(golang.org/x/sys)) bundled(golang(golang.org/x/term)) bundled(golang(golang.org/x/text)) bundled(golang(golang.org/x/time)) bundled(golang(golang.org/x/tools)) bundled(golang(google.golang.org/appengine)) bundled(golang(google.golang.org/protobuf)) bundled(golang(gopkg.in/inf.v0)) bundled(golang(gopkg.in/yaml.v2)) bundled(golang(gopkg.in/yaml.v3)) bundled(golang(k8s.io/api)) bundled(golang(k8s.io/apimachinery)) bundled(golang(k8s.io/client-go)) bundled(golang(k8s.io/klog/v2)) bundled(golang(k8s.io/kube-openapi)) bundled(golang(k8s.io/utils)) bundled(golang(sigs.k8s.io/json)) bundled(golang(sigs.k8s.io/structured-merge-diff/v4)) bundled(golang(sigs.k8s.io/yaml)) config(receptor) receptor receptor(x86-64) receptorctl: python3.12dist(receptorctl) python3dist(receptorctl) receptorctl receptorctl(x86-64) python3-receptor-python-worker: python-receptor-python-worker python3-receptor-python-worker python3-receptor-python-worker(x86-64) python3.12-receptor-python-worker python3.12dist(receptor-python-worker) python3dist(receptor-python-worker) receptor-debuginfo: debuginfo(build-id) receptor-debuginfo receptor-debuginfo(x86-64) receptor-debugsource: receptor-debugsource receptor-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/kevin/fedora/reviews/2232203-receptor/receptor.spec 2023-09-19 12:13:56.000000000 -0700 +++ /home/kevin/fedora/reviews/2232203-receptor/review-receptor/srpm-unpacked/receptor.spec 2023-09-10 17:00:00.000000000 -0700 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.3.5) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + # Generated by go2rpm 1.9.0 %bcond check 1 @@ -247,3 +257,4 @@ %changelog -%autochangelog +* Mon Sep 11 2023 John Doe <packager@xxxxxxxxxxx> - 1.4.1-1 +- Uncommitted changes Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -n receptor Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Python, Shell-api, Generic Disabled plugins: PHP, SugarActivity, fonts, Haskell, Ocaml, R, Java, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2232203 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202232203%23c5 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
