[Bug 2235064] Review Request: python-fingerprints - Compare the names of companies and people by applying strong normalisation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2235064

Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(loganjerry@gmail.
                   |                            |com)



--- Comment #3 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> ---
- The License field is wrong.  It should be MIT, not Apache-2.0.

oops

- Note this message in the build log, since 2023-Oct-30 is only 6 weeks away

/usr/lib/python3.12/site-packages/setuptools/config/setupcfg.py:293:
_DeprecatedConfig: Deprecated config in `setup.cfg`
!!
       
********************************************************************************
        The license_file parameter is deprecated, use license_files instead.
        By 2023-Oct-30, you need to update your project and remove deprecated
calls
        or your builds will no longer be supported.
        See
https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for
details.
       
********************************************************************************
!!
  parsed = self.parsers.get(option_name, lambda x: x)(value)

PR sent https://github.com/alephdata/fingerprints/pull/17

and added in the SPEC


- Remove the -t flag from %pyproject_buildrequires since this package does not
  test with tox

ok

- I don't know how seriously we take the "American English" thing, but
  "normalisation" is the British English spelling.  Thanks to Benjamin
Franklin,
  we Americans spell it with a z: "normalization".

ok

Thnaks for the review, files updated in place.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2235064

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202235064%23c3
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux