https://bugzilla.redhat.com/show_bug.cgi?id=2235087 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(zebob.m@xxxxxxxxx | |) | --- Comment #4 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- You could use it as a patch: # Remove useless shebang lines # https://github.com/nexB/urlpy/pull/12 Patch: %{url}/pull/12.patch -Z ok ===== Notes (no change is required!) ===== - You could remove the manual dependency BuildRequires: python3dist(pytest) and instead change %pyproject_buildrequires to %pyproject_buildrequires requirements-tests.txt Often, such tests requirements files are unusable because they contain a ton of linters, typecheckers, coverage tools, etc. that we don’t want (https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters), but for this package the file only contains pytest, so generating test BR’s from the requirements file is convenient and equivalent to the manual BR. -> ok - I still think that writing %URL instead of %url or %{url} is a bit surprising, but it’s not wrong. -> ok - Similarly, I think that using a %{pypi_name} macro instead of writing out the canonical name adds noise without really improving reusability, but this is only a matter of opinion. -> i copy paste spec all the time, that's why I use it. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2235087 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202235087%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
