https://bugzilla.redhat.com/show_bug.cgi?id=2238840 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |omajid@xxxxxxxxxx --- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > # Set .NET runtime identitfier string > %ifarch aarch64 > %define dotnet_rid fedora.%{fedora}-arm64 > %else > %define dotnet_rid fedora.%{fedora}-x64 > %endif This confuses me with the ExcludeArch statement in the spec: "ExcludeArch: %{power64} ppc64le %{arm}" Is the intent that this only works with x86_64 and AArch64? If that's the case, this should use "ExclusiveArch: x86_64 aarch64" > Source2: %{name}-nupkgs.tar.xz > Source3: %{name}-nupkgs2.tar.xz > [...] > dotnet nuget add source %{_builddir}/jellyfin-nupkgs -n jellyfin-nupkgs > dotnet nuget add source %{_builddir}/jellyfin-nupkgs2 -n jellyfin-nupkgs2 > dotnet nuget disable source nuget.org > dotnet nuget disable source "NuGet official package source" I'm slightly confused here. Are NuGet packages source or binary artifacts? Depending on what they are, we may need more help from the DotNet SIG. Additionally, as a general comment, this is missing bundled provides for the vendored stuff. Cf. https://docs.fedoraproject.org/en-US/fesco/Bundled_Software_policy/ > Requires: ffmpeg This should be changed to "ffmpeg-free", since that's what we have in Fedora. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2238840 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202238840%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
