https://bugzilla.redhat.com/show_bug.cgi?id=2238652 --- Comment #2 from Carl George 🤠 <carl@xxxxxxxxxx> --- > b) Building from forgesource might be cleaner as it does not contain a generated egg-info directory, > however if using sources from pypi, then may want to remove src/krb5.egg-info directory in the > prep section The Python package guidelines allow using PyPI as long as things like tests and licenses are present. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_source_files_from_pypi The rest of those guidelines make no mention of removing the egg-info directory. I do not believe it's necessary with the modern pyproject macros. > d) Should there be a -devel package with python_krb5.h ? It is currently installed in %{sitepackages}/krb5 > - see for example: https://src.fedoraproject.org/rpms/pycairo/blob/rawhide/f/pycairo.spec No, this file is an oversight and should probably be removed. I've sent a fix upstream and included it as a patch in the spec file. https://github.com/jborean93/pykrb5/pull/32 > e) The build-helper files from Heimdal are under BSD-2-Clause and BSD-3-Clause licenses. This seems > ok as none are included in the build, but helpful to confirm. Correct, they are not included and the package builds against krb5-devel, not heimdal-devel. Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/06400811-python-krb5/python-krb5.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/06400811-python-krb5/python-krb5-0.5.1-1.fc40.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2238652 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202238652%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
