https://bugzilla.redhat.com/show_bug.cgi?id=2238751 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED --- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > - generate_buildrequires needs to be during %prep, because sources must be extracted (that's also how rust-ripgrep does) This is a misunderstanding of how RPM works. You could also write this: """ %generate_buildrequires %cargo_generate_buildrequires -n %prep %autosetup -n rutabaga-gfx-%{gitdate} -p1 %cargo_prep """ And the %prep scriptlet would still get executed *before* the %generate_buildrequires scriptlet. Order of definition in the spec file does not matter to RPM, it will always execute scriptlets in the same order. > - fixed the -a/-n flags Why did you keep the "-n" flag? It has zero effect in this project. > - %cargo_build ok, however debugsourcefiles.list is still empty (breaking the build atm). Any idea how to fix find-debuginfo ? This means that something is wrong during the build process - the binaries end up without debug information, otherwise find-debuginfo would not complain. I don't know how this happens, but the build log should show "-Cdebuginfo=2" being passed to rustc. If that doesn't happen, then something is wrong. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2238751 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202238751%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
