[Bug 2238751] Review Request: rutabaga-gfx-ffi - Handling virtio-gpu protocols

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2238751



--- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
Thanks! I'll take another look later.

Note that the project's directory structure / setup is a bit unusual. It looks
like most of the functionality of this project is disabled by default:

> [features]
> gfxstream = []
> gfxstream_stub = []
> virgl_renderer = []
> virgl_renderer_next = []
> minigbm = []
> # To try out Vulkano, delete the following line and uncomment the line in "dependencies". Vulkano
> # features are just a prototype and not integrated yet into the ChromeOS build system.
> vulkano = []
> x = []

The only feature that's enabled conditionally by the Makefile is gfxstream if
the corresponding pkg-config file can be found, and this library doesn't appear
to be packaged for Fedora. So I think in fact, you don't need to pass *any*
flags to "%cargo_generate_buildrequires", "%cargo_license", or
"%cargo_license_summary", since there are not manually enabled features, and
the default feature set is empty.

===

Looking at the whole thing, I think it would be easier to just not use the
Makefile at all than to work around its limitations, especially if you need to
make any adjustments to the build process (like enabling any of the features,
or passing other flags).


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2238751

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202238751%23c4
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux