https://bugzilla.redhat.com/show_bug.cgi?id=2238751 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Just from a Rust packaging standpoint, there's two immediate red flags: 1. There's a "--no-default-features" flag passed to "%cargo_generate_buildrequires -n", but the "--all-features" flag (pretty much the *opposite one*) is passed to %cargo_license/_summary ("-a"). This is likely to cause wrong results. You should, in almost all cases, pass the same flags to *all* invocations of the %cargo_* macros, otherwise you will get inconsistent outcomes or weird errors. I don't see how "cargo build" is called inside the Makefile, but the same feature flags should also be passed to the %cargo_* macros in the spec. 2. You need to ensure that the correct compiler flags are passed to rustc. The fact that you have "%global debug_package %{nil}" probably means that the *wrong* flags are passed / hardcoded in the Makefile. If default RUSTFLAGS were respected, the output would have valid debuginfo. --- And just for better readability of the spec file, this is very confusing: > %prep > %autosetup -n rutabaga-gfx-%{gitdate} -p1 > %cargo_prep > %generate_buildrequires > %cargo_generate_buildrequires -n The %generate_buildrequires scriptlet is a top-level scriptlet just like %prep, %build, and %install, having it smushed together with %prep to make it look like it's part of %prep is likely to cause confusion. --- You might also get away with using "patchelf" to set the soname instead of patching in a custom build script. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2238751 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202238751%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
