https://bugzilla.redhat.com/show_bug.cgi?id=2238263 --- Comment #12 from Cristian Le <fedora@xxxxxxxxx> --- > > - `Release: 1%{?dist}` Should be using `rpmautospec`. Can convert it with > > using `rpmautospec convert` > > I'm still not a fan of rpmautospec. I thought this is already supposed to be enforced with f38 onwards https://fedoraproject.org/wiki/Changes/Rpmautospec_by_Default > I've reworked it now to use loops. The differences between the mpi builds doesn't make it as clean as it might be, but probably better. Thoughts? I think it does make it look neater. But you're missing pushd/popd or equivalents. I will do some experimentation around [1]. I like the approach there where a macro is defined. I want to test if it can be combined with inline evaluation of a for loop (like adding a bash for loop to the `dconfigure` definition there) > I prefer to be able to easily see if the test is still failing in the future. Fair point. For this reason I like to implement packit upstream and have an open PR to monitor the progress of that. A few final points on my side: - ``` export CFLAGS="%{optflags} -fPIC" export CXXFLAGS="%{optflags} -fPIC" export FFLAGS="%{optflags} -fPIC" ``` This is already handled by `BUILD_SHARED_LIBS`. It can be necessary if upstream uses object libraries and doesn't patch those - `%{_libdir}/libdbcsr.so.%{sover}*` I prefer simply `%{_libdir}/libdbcsr.so.*`. Thoughts? [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/MPI/#_a_sample_spec_file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2238263 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202238263%23c12 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
