Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: odccm - Connection daemon for Pocket PC devices for Windows Mobile 5 https://bugzilla.redhat.com/show_bug.cgi?id=426885 ------- Additional Comments From panemade@xxxxxxxxx 2008-01-10 03:43 EST ------- Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM. But NOT for RPM. odccm.i386: W: conffile-without-noreplace-flag /etc/dbus-1/system.d/odccm.conf =>Ok for this package + source files match upstream. ed830920a91573215d2497c09bd5a310 odccm-0.11.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + chkconfig scriptlets are used. + Package odccm-0.11-1.fc9 => Provides: config(odccm) = 0.11-1.fc9 Requires: /bin/bash config(odccm) = 0.11-1.fc9 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libdbus-1.so.3 libdbus-glib-1.so.2 libglib-2.0.so.0 libgnet-2.0.so.0 libgobject-2.0.so.0 libgthread-2.0.so.0 libhal.so.1 libpthread.so.0 libpthread.so.0(GLIBC_2.0) librt.so.1 libsynce.so.0 + Not a GUI app. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review