https://bugzilla.redhat.com/show_bug.cgi?id=2238263 Cristian Le <fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxx --- Comment #10 from Cristian Le <fedora@xxxxxxxxx> --- - I like the compact design in `elpa`[1], what do you think of using similar `pushd`, `popd` approach with `%cmake -S ../`. There the `module load mpi/openmpi-%{_arch}` are called manually. Maybe these can work with `lua` for loops? - `-DCMAKE_INSTALL_LIBDIR:PATH=lib` should be `MPI_LIB` I don't see `$MPI_HOME` to be documented. - `-DCMAKE_PREFIX_PATH` should not be necessary. Are there cmake modules installed specific for mpi flavours? Even so they should be handled by `%{_openmpi_load}` - What is the purpose of `%global _vpath_builddir %{_vendor}-%{_target_os}-build`? - ``` # Tests fail - reported https://github.com/cp2k/dbcsr/issues/703 %ctest || : ``` Are all the tests failing, if not, how about filtering the specific test? `ctest -E <regex_of_test>` - `Release: 1%{?dist}` Should be using `rpmautospec`. Can convert it with using `rpmautospec convert` - ``` # SONAME is based on major.minor version %global sover 2.6 Version: %{sover}.0 ``` I think it is best not to rely on a macro here. E.g. packit would override the `Version` text - ``` %global git 0 %global snapshot 20230905 %global commit 4d60929fea25d66ef58ab66eaced315242d8c029 %global shortcommit %(c=%{commit}; echo ${c:0:7}) ``` Are these meant to be used in production, e.g. releasing an untagged commit version? [1] https://src.fedoraproject.org/rpms/elpa/blob/rawhide/f/elpa.spec#_258 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2238263 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202238263%23c10 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
