https://bugzilla.redhat.com/show_bug.cgi?id=2238233 Davide Cavalca <davide@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Status|NEW |POST Assignee|nobody@xxxxxxxxxxxxxxxxx |davide@xxxxxxxxxxxx --- Comment #4 from Davide Cavalca <davide@xxxxxxxxxxxx> --- - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 105225510 bytes in 2544 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 57600000 bytes in /usr/share libdatachannel-devel-0.19.1-1.fc40.x86_64.rpm:57579520 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines These should be fixed by making the appropriate subpackages. There's also a ton of rpmlint warnings as it tries to parse binary samples as text files. Not sure what the right course of action is here, but probably worth reporting to rpmlint at least. Besides this, APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2238233 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202238233%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
