[Bug 426349] Review Request: mono-addins

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mono-addins


https://bugzilla.redhat.com/show_bug.cgi?id=426349





------- Additional Comments From david@xxxxxxxxxxxxx  2008-01-09 22:18 EST -------
I apologize, lots of shit going on so I kinda dropped the ball on this..

BAD:
mono-addins.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 7)
mono-addins-devel.x86_64: W: summary-not-capitalized development files for
mono-addins
mono-addins-devel.x86_64: W: non-standard-group Development/Applications
mono-addins-debuginfo.x86_64: E: empty-debuginfo-package
Fails to build in mock (fedora-8-i386) due to missing dependency fulfilling
autoreconf

GOOD:
Owns all it's files
SPEC is in clean US English

MERGH?:
Are the --prefix/libdir configure arguments really needed?
It's good form to name patches after it's function instead of just the package
name (so in this case mono-addins-libdir.patch would be good I suppose).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]