https://bugzilla.redhat.com/show_bug.cgi?id=2235768 Jonathan S. <js-fedora@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(benson_muite@emai | |lplus.org) --- Comment #3 from Jonathan S. <js-fedora@xxxxxx> --- Thanks for the review! a.) WDYM? It already has %license LICENSE.GPLv3? b.) Done - with the SuSE leftover removed. Sorry, I copied it from a .spec file I had for both that was for snapshots. c.) Removed entirely, it's not needed for non-development versions (for which said .spec file was). d.) The entire idea is that "objfw" is a meta-package pulling in everything. If I remove this, this would no longer be the case, no? e.) Done. second d.) The idea was that you can install everything individually. Only need the library as a dependency? Great, get libobjfw and libobjfwrt. Only want ofhttp to download a file? Great, just get libobjfw, libobjfwrt, libobjfwtls and ofhttp, without the -devel. Want to develop? Get libobjfw-devel. Want it all? Get objfw. second e.) Yes, OpenSSL 3 works fine. OpenSSL 1.1.1 is just the minimum. I increased the minimum to 3.0.0, is that correct? f.) D'oh. I even added the keyring and then forgot to actually check it. Done. g.) WDYM? There already is a %check in there? h.) Done. Updated spec file: https://nil.im/objfw.spec -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2235768 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202235768%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
