[Bug 2237101] Review Request: rust-include_dir - Embed the contents of a directory in your binary

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2237101

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |decathorpe@xxxxxxxxx
           Doc Type|---                         |If docs needed, set a value
             Status|NEW                         |ASSIGNED
         Depends On|                            |2237102
                   |                            |(rust-include_dir_macros)



--- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
Package looks good so far, I'll continue with the review once
include_dir_macros are imported.

But adding a comment why integration tests are disabled would be good:
> rm -rfv tests/

Alternatively, you can keep the files and change the %cargo_test arguments:

%cargo_test -- --lib
%cargo_test -- --doc



Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2237102
[Bug 2237102] Review Request: rust-include_dir_macros - Procedural macro used
by include_dir
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2237101

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202237101%23c1
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux