https://bugzilla.redhat.com/show_bug.cgi?id=2237014 --- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> --- I've updated the spec + srpm based on some of the feedback, rest addressed below: (In reply to Davide Cavalca from comment #1) > Quick pass: > > - source package should probably be called golang-github-google-fscrypt for > consistency (and use fscrypt for the binary package) Go packaging guidelines apparently state well-known name should be used for the source package name. Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_source_packages_src_rpm > - in godocs and docs cli-tests/README.md will overwrite README.md; if both > are needed one needs to be renamed in %prep (but I suspect we can drop the > cli-tests one) Dropped the cli-tests/README.md. > - the bash completion stuff either needs a Requires: bash-completion, or it > needs to own the various completion paths (most packages do the latter) The bash completion directories are owned by filesystem. I don't need to do anything here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2237014 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202237014%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
