[Bug 2224783] Review Request: dragonbox - Reference implementation of Dragonbox in C++

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2224783



--- Comment #7 from Mattia Verga <mattia.verga@xxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #6)
> Hmm, so what is in the .a file? If it is not needed for anything, maybe drop
> it and make the -devel
> package noarch?
> 

I'm not really expert of C, but here are an excerpt from the README:
"""
Although Dragonbox is intended for float-to-string conversion routines, the
actual string generation is not officially a part of the algorithm. Dragonbox
just outputs two integers (the decimal significand/exponent) that can be
consumed by a string generation procedure. The header file
include/dragonbox/dragonbox.h includes everything needed for this (it is
header-only). Nevertheless, a string generation procedure is included in the
library. There are two additional files needed for that:
include/dragonbox/dragonbox_to_chars.h and source/dragonbox_to_chars.cpp.
"""

If you think it isn't worth to distribute the .a file, the instructions say I
can use '-DDRAGONBOX_INSTALL_TO_CHARS=OFF' to disable building the library.
I'll have to check if LibreOffice build just requires the headers, though,
since this is the only reason to package dragonbox.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2224783

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202224783%23c7
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux