https://bugzilla.redhat.com/show_bug.cgi?id=2236138 --- Comment #3 from Sandro <gui1ty@xxxxxxxxxxxxx> --- (In reply to Mathieu Bridon from comment #2) > Ok, here goes nothing... Do note that this is my first review since my > "accident" in 2020, so I'm completely out of the game and I might be doing > mistakes, but fedora-review hadthis to say: No worries. We go through it together. > Issues: > > [!]: License file installed when any subpackage combination is installed. > -> you didn't install the LICENSE file at all It is installed automagically by the Python RPM macros: rpm -q --licensefiles -p python3-pyroaring-0.4.2-1.fc40.x86_64.rpm warning: python3-pyroaring-0.4.2-1.fc40.x86_64.rpm: Header V4 RSA/SHA256 Signature, key ID decc5810: NOKEY /usr/lib64/python3.12/site-packages/pyroaring-0.4.2.dist-info/LICENSE > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > ======= > - Dist tag is present. That's save to ignore. > - Package must not depend on deprecated() packages. > Note: python3-cython0.29 is deprecated, you must not depend on it. > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/deprecating-packages/ Well, since the package doesn't build with the newer Cython, I'd say that's permissible. But I'll check with Python folks to make sure. > ===== MUST items ===== > [!]: License file installed when any subpackage combination is installed. > -> you didn't install the LICENSE file at all See above. > [?]: Sources are verified with gpgverify first in %prep if upstream > publishes signatures. > Note: gpgverify is not used. That's a [-], since gpgverify is not used. Some projects use it. In that case the sources should be verified. > [?]: Package should compile and build into binary rpms on all supported > architectures. I guess I could do a scratch build and see if it builds on all archs: https://koji.fedoraproject.org/koji/taskinfo?taskID=105533659 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2236138 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202236138%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
