https://bugzilla.redhat.com/show_bug.cgi?id=2233128 --- Comment #9 from Adam Williamson <awilliam@xxxxxxxxxx> --- Yeah...I'm not entirely an expert in the domain, but I think you're right, shipping minified JS without the minification happening during the build violates https://docs.fedoraproject.org/en-US/packaging-guidelines/JavaScript/#_compilationminification . Apologies for not spotting that during review. It might be worth asking someone with more experience in packaging this kind of thing... I do note most of those are in the ui2/ tree. ui3 has only a minified jquery (2.2.4). httpbin uses ui3. So we might be able to handle this at least enough for httpbin...we can not ship ui2, and provide jquery in a compliant way? Unfortunately, js-jquery is jquery 3.x, and js-jquery2 was retired long ago, but we might at least be able to bundle a non-minified original jquery2 and minify it at build time, or just *not* minify it since httpbin isn't really meant for use over networks at all? Another option would be to make httpbin's use of flasgger optional. It's not really *necessary*, is it? It's just for generating API docs. We might be able to send a PR upstream for httpbin that skips the flasgger stuff if it's not present? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2233128 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202233128%23c9 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
