https://bugzilla.redhat.com/show_bug.cgi?id=2233128 Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mikel@olasagasti. | |info) | --- Comment #6 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- Spec URL: https://mikel.olasagasti.info/tmp/fedora/python-flasgger.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/python-flasgger-0.9.7.1-1.fc38.src.rpm > python3-flasgger.noarch: E: zero-length /usr/lib/python3.12/site-packages/flasgger/ui2/static/css/typography.css Removed > python3-flasgger.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/flasgger/ui2/templates/flasgger/o2c.html /usr/lib/python3.12/site-packages/flasgger/ui2/static/o2c.html flasgger offers a template in case the user wants to edit the UI. I would leave it as is. > * The Droid Sans font is bundled (in /usr/lib/python3.12/site-packages/flasgger/ui2/static/fonts). This affects the licensing - Droid Sans is licensed under the Apache License 2.0, not MIT - and is against the guidelines. It may be best to drop the bundled files, add a dep on google-droid-sans-fonts , and symlink the files from that package into the locations where flasgger expects them to be (this would also resolve the licensing qualm, I guess). Note, I'm not sure what's up with all the 'droid-sans-v6-latin-700' and 'droid-sans-v6-latin-regular' files, especially the eot, svg, and woff files - can you look into that and figure out what they are and why they're needed? ui2 uses droid as part of the css (font-family:Droid Sans). Wouldn't just requiring the google-droid-sans-fonts package be enough in this case? I created the link in the spec, but could be removed. Now I realize that UI has mulitple js files: static/lib/jquery-1.8.0.min.js static/lib/es5-shim.js static/lib/js-yaml.min.js static/lib/handlebars-4.0.5.js static/lib/jsoneditor.min.js static/lib/swagger-oauth.js static/lib/sanitize-html.min.js static/lib/object-assign-pollyfill.js static/lib/highlight.9.1.0.pack.js static/lib/lodash.min.js static/lib/jquery.slideto.min.js static/lib/jquery.ba-bbq.min.js static/lib/jquery.wiggle.min.js static/lib/backbone-min.js static/lib/marked.js static/lib/highlight.9.1.0.pack_extended.js static/swagger-ui.min.js As shipping this is not allowed, I think it's quite complex to package flasgger. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2233128 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202233128%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
