https://bugzilla.redhat.com/show_bug.cgi?id=2231013 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide ? test suite is run and all unit tests pass (tests are disabled, reason is documented) ? latest version of the crate is packaged (I assume you need v0.6, so this is fine) - license matches upstream specification (BSD-2-Clause) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === Three non-blocking comments: 1. You need to exclude generate-readme.sh from the installed files. Otherwise the package will have an unnecessary generated dependency on /usr/bin/bash. You can either patch Cargo.toml to add an "exclude" setting, or use "%exclude %{crate_instdir}/generate-readme.sh" in the %files list of the -devel subpackage. 2. If you patch Cargo.toml, you MUST do that by passing the "-p" flag to "rust2rpm". Patches to Cargo.toml can affect spec file generation, and only changes made by generating a patch with "rust2rpm -p" can be taken into account (obviously). 3. Note that you messed up the spec file for rust-zerocopy-derive on import. You need to import the *unmodified* spec file (i.e. not the one from inside the SRPM / not processed by rpmautospec). Please take care of that when importing this package. I fixed the rust-zerocopy-derive issue: https://src.fedoraproject.org/rpms/rust-zerocopy-derive/c/507dd2022c6e91fd1748e1862ab6ad2ef8e212d9?branch=rawhide === PS: I will likely request stable dist-git branches of zerocopy / zerocopy-derive at some point, since it will allow us to enable currently disabled optional features of a handful of other crates. PPS: I wonder what you are packaging this crate for? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2231013 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202231013%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
