https://bugzilla.redhat.com/show_bug.cgi?id=2180243 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #14 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'GPL-3.0-only WITH Font-exception-2.0 AND GPL-2.0-or-later AND LGPL-3.0-only AND LGPL-2.1-or-later AND MIT AND (Unlicense OR MIT-0) AND (Unlicense or MIT)'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Watch out for the last or, it must be capitalized: License: GPL-3.0-only WITH Font-exception-2.0 AND GPL-2.0-or-later AND LGPL-3.0-only AND LGPL-2.1-or-later AND MIT AND (Unlicense OR MIT-0) AND (Unlicense OR MIT) - Why Epoch is 1? This is a new package, you don't need Epoch. - Use autorelease/autochangelog - could you unbundle googletest? thirdparty/googletest We have googletest in Fedora - could you patch the FSF address and send it upstream musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.1/styles/cchords_muse.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.1/styles/cchords_nrb.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.1/styles/cchords_rb.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.1/styles/cchords_sym.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.1/styles/chords.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.1/styles/chords_jazz.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.1/styles/chords_std.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.1/styles/jazzchords.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.1/styles/stdchords.xml - could you message upstream about this incorrect address (but don't patch)) musescore.x86_64: E: incorrect-fsf-address /usr/share/licenses/musescore/COPYING.LESSER.rtf2html - [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 55623680 bytes in /usr/share musescore-4.1.1-1.fc40.x86_64.rpm:55623680 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines We have lots of data in /usr/share that should be split into a noarch package, i.e. make a separate data noarch package for everything under /usr/share/mscore-4.1 - Will check licensing further in the next comemnt. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'GPL-3.0-only WITH Font-exception-2.0 AND GPL-2.0-or-later AND LGPL-3.0-only AND LGPL-2.1-or-later AND MIT AND (Unlicense OR MIT-0) AND (Unlicense or MIT)'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 3", "*No copyright* GNU General Public License, Version 3", "GNU General Public License, Version 2 [obsolete FSF postal address (Mass Ave)]", "Creative Commons Attribution 3.0", "SIL Open Font License 1.1", "GNU General Public License, Version 3 GNU General Public License, Version 2", "SIL Open Font License", "*No copyright* SIL Open Font License 1.1", "*No copyright* SIL Open Font License", "GNU General Public License v3.0 or later", "MIT License", "GNU Lesser General Public License, Version 3", "GNU General Public License, Version 2", "GNU General Public License v2.0 or later", "*No copyright* GNU General Public License v2.0 or later", "Apache License 2.0", "*No copyright* Apache License 2.0", "BSD 3-Clause License", "*No copyright* MIT License", "GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License", "GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Temple Place)]", "GNU General Public License, Version 2 [obsolete FSF postal address (Temple Place)]", "*No copyright* GNU General Public License", "GNU Lesser General Public License v2.1 or later", "*No copyright* GNU Lesser General Public License", "*No copyright* GNU General Public License, Version 2", "FSF All Permissive License", "GNU Lesser General Public License, Version 3 GNU General Public License, Version 2", "GNU Lesser General Public License, Version 2.1 GNU General Public License, Version 3", "Apache License 2.0 [generated file]", "BSD 3-Clause License [generated file]", "GNU Lesser General Public License v3.0 or later", "GNU General Public License GNU Lesser General Public License v2.1 or later", "*No copyright* GNU Lesser General Public License v2.1 or later", "BSD 2-Clause License", "*No copyright* zlib License", "*No copyright* Boost Software License 1.0", "Boost Software License 1.0", "*No copyright* BSD 3-Clause License", "GNU Library General Public License v2 or later", "*No copyright* Public domain", "Unicode License Agreement - Data Files and Software (2016)". 5915 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/musescore/review-musescore/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/SMuFL(finale-ash- text-fonts, finale-ash-fonts, finale-legacy-fonts, finale-broadway- legacy-text-fonts, finale-jazz-text-lowercase-fonts, finale-maestro- text-fonts, finale-broadway-text-fonts, finale-maestro-fonts, finale- engraver-fonts, finale-jazz-text-fonts, finale-jazz-fonts, finale- broadway-fonts), /usr/share/SMuFL/Fonts(finale-ash-text-fonts, finale- ash-fonts, finale-legacy-fonts, finale-broadway-legacy-text-fonts, finale-jazz-text-lowercase-fonts, finale-maestro-text-fonts, finale- broadway-text-fonts, finale-maestro-fonts, finale-engraver-fonts, finale-jazz-text-fonts, finale-jazz-fonts, finale-broadway-fonts) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 43276 bytes in 13 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in musescore-soundfont , mscore-fonts , mscoretext-fonts , musescoreicon- fonts , mscorebc-fonts , mscoretabulature-fonts , musejazz-fonts , musejazz-text-fonts , gootville-fonts , gootville-text-fonts [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 55623680 bytes in /usr/share musescore-4.1.1-1.fc40.x86_64.rpm:55623680 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: musescore-4.1.1-1.fc40.x86_64.rpm musescore-soundfont-0.2.0-1.fc40.noarch.rpm mscore-fonts-2.002-1.fc40.noarch.rpm mscoretext-fonts-1.0-1.fc40.noarch.rpm musescoreicon-fonts-1.0-1.fc40.noarch.rpm mscorebc-fonts-1.0-1.fc40.noarch.rpm mscoretabulature-fonts-001.000-1.fc40.noarch.rpm musejazz-fonts-1.0-1.fc40.noarch.rpm musejazz-text-fonts-1.0-1.fc40.noarch.rpm gootville-fonts-1.3-1.fc40.noarch.rpm gootville-text-fonts-1.2-1.fc40.noarch.rpm musescore-debuginfo-4.1.1-1.fc40.x86_64.rpm musescore-debugsource-4.1.1-1.fc40.x86_64.rpm musescore-4.1.1-1.fc40.src.rpm ============================================================================================================================================== rpmlint session starts ============================================================================================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpt99e41ae')] checks: 31, packages: 14 musescore-soundfont.noarch: W: no-documentation musescore.x86_64: E: incorrect-fsf-address /usr/share/licenses/musescore/COPYING.LESSER.rtf2html musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.1/styles/cchords_muse.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.1/styles/cchords_nrb.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.1/styles/cchords_rb.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.1/styles/cchords_sym.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.1/styles/chords.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.1/styles/chords_jazz.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.1/styles/chords_std.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.1/styles/jazzchords.xml musescore.x86_64: E: incorrect-fsf-address /usr/share/mscore-4.1/styles/stdchords.xml musescore.x86_64: W: incoherent-version-in-changelog 1:4.1.1-1 ['4.1.1-1.fc40', '4.1.1-1'] musescore.x86_64: W: files-duplicate /usr/share/mscore-4.1/locale/musescore_ar_DZ.qm /usr/share/mscore-4.1/locale/instruments_ar_DZ.qm ============================================================================================================ 14 packages and 0 specfiles checked; 10 errors, 1042 warnings, 10 badness; has taken 7.4 s ============================================================================================================ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2180243 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202180243%23c14 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
