https://bugzilla.redhat.com/show_bug.cgi?id=2234761 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags| |fedora-review+ Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx CC| |decathorpe@xxxxxxxxx --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Two minor issues: 1. It looks like you disabled schemars and zerocopy support, please remember to import the rust2rpm.conf file you used as well. 2. The summary is too long, from rpmlint: rust-four-cc+serde-devel.noarch: E: summary-too-long Newtype wrapper providing a convenient representation of four-character-code values rust-four-cc+default-devel.noarch: E: summary-too-long Newtype wrapper providing a convenient representation of four-character-code values rust-four-cc+std-devel.noarch: E: summary-too-long Newtype wrapper providing a convenient representation of four-character-code values rust-four-cc-devel.noarch: E: summary-too-long Newtype wrapper providing a convenient representation of four-character-code values rust-four-cc+nightly-devel.noarch: E: summary-too-long Newtype wrapper providing a convenient representation of four-character-code values Please trim to something shorter (maybe "Convenient representation of four-character-code values"). Not sure what four-character-code is though, so ... feel free to come up with something better. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2234761 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202234761%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
