[Bug 2227397] Review Request: libsixel - SIXEL encoding and decoding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2227397

Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |fedora@xxxxxxxxxx



--- Comment #1 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> ---
> %files
> [...]
> %{_libdir}/libsixel.a
> %{_libdir}/libsixel.so
> %{_libdir}/libsixel.so.1
> %{_libdir}/libsixel.so.1.0.0
>
> %files devel
> %{_bindir}/libsixel-config
> %{_includedir}/sixel.h
> %{_libdir}/pkgconfig/libsixel.pc
Two things here:
1) The unversioned .so file should go in the -devel package.
   https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages
2) Building static libraries (.a) is discouraged. If you want to keep it,
   then it should go into a separate -static package.
  
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static_libraries

> * Sat Jul 29 2023 ErrorNoInternet <errornointernet@xxxxxxxx> - 1.10.3-1
> - Hello, world!
Hello, indeed! You way want to change this to "Initial packaging" or something
of the like. :)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2227397

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202227397%23c1
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux