https://bugzilla.redhat.com/show_bug.cgi?id=2222844 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxxx --- Comment #8 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- Overall the package looks good, just two suggestions from my side: Usually with library packages, the main package contains the dynamic libraries, and -devel the header files. Any extra tools can either go into the main package, or into a -tools subpackage. Since qoi is (currently?) a header-only library, I think it could be a good idea to move the tools into a -tools subpackage, and omit building the main package. This would enable you to make the devel package noarch and save users from having to install unneeded dependencies. In Makefile-ldflags.patch, you put LDFLAGS next to CFLAGS. It's usually best to place these at the end of the compiler invocation. Sorry for the long wait. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2222844 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202222844%23c8 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
