https://bugzilla.redhat.com/show_bug.cgi?id=2232507 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #11 from Fabio Valentini <decathorpe@xxxxxxxxx> --- The systemd BRs and Requires don't look right, see: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd i.e. this is missing: BuildRequires: systemd-rpm-macros The manual "Requires(pre/post/postun): systemd" are also outdated: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_dependencies_on_the_systemd_package they should either be replaced with "%{?systemd_requires}" or dropped entirely, since they are not required for the %post, %pre, and %postun scriptlets to work. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2232507 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202232507%23c11 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
