https://bugzilla.redhat.com/show_bug.cgi?id=2233678 Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |dominik@xxxxxxxxxxxxxx Flags| |fedora-review+ --- Comment #9 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- Package builds fine in rawhide mock. rpmlint has a complaint: pianobar.spec:65: E: use-of-RPM_SOURCE_DIR pianobar-devel.x86_64: W: no-documentation but this is sha256 checksum verification, so we can ignore it. License is correct and valid SPDX. Application is console-based, so no desktop file required. There's an rpmbuild warning to be addressed: RPM build warnings: File listed twice: /usr/lib64/libpiano.so.0 You're missing a dot before the asterisk (*) in the line below: %{_libdir}/libpiano.so.0{,*} The package looks good otherwise, though I can't test it apart from that it doesn't crash on startup, because it requires a pandora.com account. Please address Neal's comment and the one above and the package is APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2233678 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202233678%23c9 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
