https://bugzilla.redhat.com/show_bug.cgi?id=2232507 --- Comment #6 from Richard Hughes <rhughes@xxxxxxxxxx> --- > a) Does not build on Fedora 37, but this is not essential. Agree; I've been quite aggressive with BRs and not including compat code for the old libsoup. > b) Consider adding: > %dir %{_includedir}/passim-1/ > %dir %{_datadir}/passim/ > to ensure these directories are owned by the package Good catch, thanks. Added -- new spec and srpm uploaded in the same place. > c) Following https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage > should there be a line: > appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/*.metainfo.xml TIL; thanks! Added. Richard -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2232507 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202232507%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
