https://bugzilla.redhat.com/show_bug.cgi?id=2119987 --- Comment #6 from Simone Caronni <negativo17@xxxxxxxxx> --- Spec URL: https://slaanesh.fedorapeople.org/python-icapclient3.spec SRPM URL: https://slaanesh.fedorapeople.org/python-icapclient3-1.2.1-2.fc38.src.rpm (In reply to Maíra Canal from comment #2) > > %global srcname icapclient3 > > Another readability nit, setting and using this makes the spec file harder > to read. Using the literal name makes it easier to read. Moreover, sometimes > you don't even use this macro and write "icapclient3" literally. I've left the srcname macro in, otherwise the shortcut of pypi_source in the Source URL will not work, it expects the srcname macro to be declared. > > %{?python_provide:%python_provide python3-%{srcname}} > > This is deprecated and shouldn't be used. Check the note at the end of > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/ > #_the_py_provides_macro Removed. @frank@xxxxxxxxxxxxxxxxxx the SPEC file as is builds on EL9 and Fedora. At work we use it also on EL8, I will make a different one for the EL7/EL8 branches after approval. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2119987 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202119987%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
