https://bugzilla.redhat.com/show_bug.cgi?id=2233324 --- Comment #4 from Kalev Lember <klember@xxxxxxxxxx> --- Thanks a lot for reviewing this and all of the dependencies. I really appreciate the help here. > Some notes for things that might or might not warrant additional changes: > > 1. Package requires other packages for directories it uses. > Note: No known owner of /usr/share/help/fa > > Unsure what this is about. Is "fa" some language identifier that is > non-standard and not known by our tools? Looks like it's Persian (Farsi) and part of ISO 639-1, but apparently all of the directories in /usr/share/help are in limbo: if I do `rpm -qf /usr/share/help/*`, some directories are owned by deja-dup, but most are listed as unowned. I'd say maybe 'filesystem' should own them all? What do you think? Alternatively, we'd need to fix %find_lang to mark them as owned by individual packages - either way, the fix is not in this package. > 2. Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/help/fa, > /usr/share/dbus-1, /usr/share/help/uk, /usr/share/help/C, > /usr/share/dbus-1/services > > Does the package need to require dbus, or should it co-own /usr/share/dbus-1? I would say it makes sense to require dbus because even basic functions like launching the app happen over dbus (it has DBusActivatable=true in the desktop file). > 3. The package has cargo tests, so it *needs* to have "%bcond_without check". > Otherwise, any test-only dependencies might not be present for compiling > tests. This might work right now, but could break with any future version. > > I guess I should really document this (or flip the default for > %cargo_generate_buildrequires if neither with/without are defined...) Fixed. > 4. Replace "BR: rust-packaging" with "BR: cargo-rpm-macros". The former no > longer exists, and is only provided by the latter for backwards > compatibility. Fixed. -- Thanks again for all the help, Fabio! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2233324 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202233324%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
