https://bugzilla.redhat.com/show_bug.cgi?id=2233248 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #7 from Fabio Valentini <decathorpe@xxxxxxxxx> --- If you lay out your project's directory structure in the conventional way, cargo will auto-detect binaries, tests, examples, benchmarks for you, without having to list them all manually in Cargo.toml with [[bin]], [[example]], [[test]], or [[bench]] targets. You only need to manually specify these compilation targets if they need non-default settings: https://doc.rust-lang.org/cargo/reference/cargo-targets.html#target-auto-discovery In this case: Files that match src/bin/*.rs (the convention for projects that ship multiple executables) are automatically detected as executables - as would be src/main.rs (the convention for single-executable projects). Hope that makes sense. Package looks good to me now! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged ~ license matches upstream specification (LGPL-2.1-*) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === Note that %cargo_license and %cargo_license_summary macros operate on cargo metadata - so for these to pick up the fixed license identifier correctly, you would also need to patch it in Cargo.toml (in addition to the "autobins = false" thing). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2233248 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202233248%23c7 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
