https://bugzilla.redhat.com/show_bug.cgi?id=2233278 --- Comment #4 from Kalev Lember <klember@xxxxxxxxxx> --- (In reply to Fabio Valentini from comment #1) > Quick comment: Assuming that the upstream project uses SemVer version > strings like Rust crates, you should be able to use %{version_no_tilde} > instead of defining a tarball_version macro yourself. I'll run the full > review once rust-glycin is imported. Ah yes. I just went with the same thing that we've used in all the other GNOME packages that come from download.gnome.org. We should probably change them all to use %{version_no_tilde}. Let's keep it as is for now for consistency with other GNOME stuff (but I agree with you). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2233278 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202233278%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
