Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: diveintopython - The html book https://bugzilla.redhat.com/show_bug.cgi?id=389971 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From kevin@xxxxxxxxx 2008-01-08 20:16 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GFDL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 09247597b21c6253b810f081053e56b5 diveintopython-html-5.4.zip 09247597b21c6253b810f081053e56b5 diveintopython-html-5.4.zip.sav OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. See below - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version Issues: 1. The html subpackage should own: /usr/share/diveintopython-html/ The pdf should own: /usr/share/diveintopython-pdf etc. ie, they are missing ownership of the top level datadir/name dir. 2. rpmlint says: diveintopython.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 30) Suggest: Might use only spaces or only tabs. Not a blocker. diveintopython-html.noarch: W: wrong-file-end-of-line-encoding /usr/share/diveintopython-html/diveintopython.css/diveintopython.css diveintopython-single-html.noarch: W: wrong-file-end-of-line-encoding /usr/share/diveintopython-single-html/diveintopython.css/diveintopython.css diveintopython-txt.noarch: W: wrong-file-end-of-line-encoding /usr/share/diveintopython-single-html/diveintopython.css/diveintopython.css The css file is CR/LF... I don't think this matters as long as it's properly read. Suggest: Ignore, unless you see problems loading it. Issue #1 is pretty minor, provided you fix that before importing this package, this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review