[Bug 2231940] Review Request: golang-modernc-cc -Package CC is a C99 compiler front end

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2231940

Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
                   |                            |needinfo?(mike@xxxxxxxx)
                 CC|                            |zebob.m@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx



--- Comment #1 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> ---
I'm not okay with that SPEC:

# https://gitlab.com/cznic/cc
%global goipath         modernc.org/cc
%global forgeurl        https://gitlab.com/cznic/cc
Version:                3.39.0


Latest version in v3 is v3.41.0

If you want to package v3, use the v3 import path:

modernc.org/cc/v3


And thus call your package:

golang-modernc-cc-3


(including the spec filename and this bug title)

 - Then, like I said in my mail:

find . ! \( -name v3 -o -name _build \) -maxdepth 1 -exec rm -rvf {} \;
mv v3/* . 


-> we delete all the files except v3, and we move v3 files to the root of the
packages.


SPEC should look like this:

# golang-modernc-cc.spec
# Generated by go2rpm 1.9.0
%bcond_without check
%global debug_package %{nil}

# https://gitlab.com/cznic/cc
%global goipath         modernc.org/cc/v3
%global forgeurl        https://gitlab.com/cznic/cc
Version:                3.41.0
%global tag             v%{version}

%gometa -f

%global common_description %{expand:
Package CC is a C99 compiler front end.}

%global golicenses      GO-LICENSE LICENSE
%global godocs          docs README.md AUTHORS CONTRIBUTORS

Name:           %{goname}
Release:        %autorelease
Summary:        C99 compiler front end

License:        BSD-3-Clause
URL:            %{gourl}
Source:         %{gosource}
Patch:          cc-v3.39.0-s390x.patch

%description %{common_description}

%gopkg

%prep
%goprep
%autopatch -p1
find . ! \( -name v3 -o -name _build \) -maxdepth 1 -exec rm -rvf {} \;
mv v3/* .

%generate_buildrequires
%go_generate_buildrequires

%install
%gopkginstall

%if %{with check}
%check
%gocheck
%endif

%gopkgfiles

%changelog
%autochangelog


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2231940

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202231940%23c1
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux