[Bug 2203715] Review Request: gmult - Multiplication Puzzle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2203715



--- Comment #4 from Yaakov Selkowitz <yselkowi@xxxxxxxxxx> ---
(In reply to Kalev Lember from comment #2)
>   Can you fix the line wrapping so that rpmlint is happy?

Done.

>   In addition to GPL licensed source code, a few files appear to be under
> different licenses:
>   The .ui files in data/ui/ under CC-BY-SA-4.0, and /po/LINGUAS and
> po/POTFILES.in under CC0-1.0.
>   Can you include those two licenses in the license field as well, please? 

Added CC-BY-SA-4.0.  But LINGUAS and POTFILES.in are build system files, and
License is supposed to reflect the *binary* package(s).

>   There is also LICENSES/ directory that has the other two missing license
> texts and these should be included in %license as well.

Done wrt CC-BY-SA-4.0.

>   It builds for f38, but fails for rawhide.

This was filed three months ago, before the new gtk4 version landed.  I have
incorporated a fix for the apparent API change in 4.12, but it needs to be
applied conditionally so that this can still be built with 4.10 (F38).


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2203715

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202203715%23c4
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux