[Bug 2149698] Review Request: sile - The SILE Typesetter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2149698

Jonny Heggheim <hegjon@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Link ID|                            |Github
                   |                            |sile-typesetter/sile/issues
                   |                            |/669



--- Comment #5 from Jonny Heggheim <hegjon@xxxxxxxxx> ---
(In reply to Robert-André Mauchin 🐧 from comment #4)
>  - Please use autochangelog/autorelease

I will update the spec.


>  - Requires: libtexpdf = %{version}
> 
> -> should include arch:

Yes, arch should also be included.

> 
> 
> Requires:  libtexpdf%{?_isa} = %{version}-%{release}
> 
>  - Why is this bundled? Was it modified by the project?

I think it is extracted from Tex Live into its own git repo by the SILE team.
This git repo have no releases.
This git repo have only been integrated with SILE as a git submodule.


> 
> Provides: bundled(lua-lunamark)
> 
>  - Same question about libtexpdf

Seems like they are working on unbundling lunamark:
https://github.com/sile-typesetter/sile/issues/669

> 
> %package -n libtexpdf
> Summary: bundled with SILE
> 
> It seems that it is straight taken from another repo. Why don't you package
> it separately?
> 
> Also that Summary is a no go. We don't care about the fact that it is
> bundled in the summary, the user needs to know what this package do.

That is a good point.

> 
> I saw https://github.com/sile-typesetter/libtexpdf/issues/25 and it seems
> there is no release tarball anymore, but you can still grab an archive from
> a commit.
> 
> I saw this too
> https://github.com/sile-typesetter/libtexpdf/issues/3#issuecomment-
> 1301767989 but there is a cmake script now and you only need zlib and libpng.
> 
> Please consider it.

I will try to package it directly from the commit that is used by SILE.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2149698

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202149698%23c5
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux