https://bugzilla.redhat.com/show_bug.cgi?id=2231252 --- Comment #28 from Keyue Hu <hukeyue@xxxxxxxxxxx> --- (In reply to Benson Muite from comment #27) > System libraries are much preferred, even if header only. Expect one of the > reasons for this is that if there is an issue with the library, then one can > much more easily find all the packages that depend on it and have built using > it and then update them. Okay, I'll update the spec to use header-only nlohmann/json (i.e. json-devel in fedora repository) library. For other c++ libraries(such as boringssl, quiche, abseil-cpp, googletest and googlemock), I think it is better to use bundled one. > > Automated review at: > https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora- > review-2231252-yass/fedora-rawhide-x86_64/06271304-yass/fedora-review/review. > txt > gives the following warning: > yass.x86_64: W: file-not-in-%lang /usr/share/locale/en/LC_MESSAGES/yass.mo It seems good that %lang works well even in RHEL7/CentOS7. Changelog: Fixed %lang usage and json-devel along with other upstream changes. Spec URL: https://github.com/Chilledheart/copr-yass/releases/download/1.3.14-52/yass.spec SRPM URL: https://github.com/Chilledheart/copr-yass/releases/download/1.3.14-52/yass-1.3.14-52.fc37.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2231252 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202231252%23c28 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
