https://bugzilla.redhat.com/show_bug.cgi?id=2230617 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > BuildArch: noarch This is not allowed on the main package, only on the devel subpackage. Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries > rm -rf %{name}-%{version} > unzip -d %{name}-%{version} %{SOURCE0} > cd %{name}-%{version} This can be simplified to "%autosetup -c" > # change dos endings to unix > sed -i "s|\r||g" include/half.hpp > sed -i "s|\r||g" LICENSE.txt > sed -i "s|\r||g" README.txt I'm a bit wary of using sed for this when "dos2unix" is perfectly suitable here. Add "BuildRequires: dos2unix" and use the tool for this instead. > cd %{name}-%{version} This is no longer required, since %autosetup configures the %install phase correctly > mkdir -p %{buildroot}%{_docdir}/%{name}/ > install -m 644 LICENSE.txt %{buildroot}%{_docdir}/%{name}/ > install -m 644 README.txt %{buildroot}%{_docdir}/%{name}/ This can all be dropped, because we can manage this from %files... > %doc %{_docdir}/%{name}/README.txt > %license %{_docdir}/%{name}/LICENSE.txt This can be replaced with "%doc README.txt" and "%license LICENSE.txt". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2230617 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202230617%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
