https://bugzilla.redhat.com/show_bug.cgi?id=2148993 Davide Cavalca <davide@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |davide@xxxxxxxxxxxx --- Comment #4 from Davide Cavalca <davide@xxxxxxxxxxxx> --- Some notes: - in %install use cp -p to preserve timestamps - instead of copying LICENSE and README in %{_datadir}/Caffe just flag them with %license / %doc - use something like find %{buildroot} -name .gitignore -exec rm '{}' \; instead of the for loop to clean up gitignore - any particular reason we're explicitly disabling python? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2148993 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202148993%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue