https://bugzilla.redhat.com/show_bug.cgi?id=2224616 --- Comment #4 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- > - Can anything be done about the duplicated files (see the rpmlint output), or is that normal for golang packages? It's how the macros work. I'll look if we can change that somehow. > - The BSD-3-Clause license seems to apply to vendored dependencies (gopsutil and schema). Can those be unbundled? If not, shouldn't the spec file contain "Provides: bundled(...)"? Note that other vendored dependencies have the same license as this package (MIT): go-ole and wmi. Yes it seems they have sneakily vendored stuff: - gopsutil, for which go-ole and wmi are deps. Fortunately, we have github.com/shirou/gopsutil in Fedora. - schema, which comes from github.com/gorilla/schema. I can't unbundle it because they made modifications to the code, if I try, tests don't pass. So we'll do: # MIT: main package # BSD-3-Clause: internal/schema taken from github.com/gorilla/schema License: MIT amd BSD-3-Clause and: rm -rfv internal/go-ole internal/gopsutil internal/wmi sed -i "s|github.com/gofiber/fiber/v2/internal/gopsutil|github.com/shirou/gopsutil|" $(find . -iname "*.go" -type f) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2224616 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202224616%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
