[Bug 2090707] Review Request: cr-marcstevens-snippets - Collection of useful one-file C/C++ headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2090707

Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
LGTM, XXX APPROVED XXX

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[-]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT License", "*No copyright* Boost Software License 1.0",
     "Unknown or generated", "Boost Software License 1.0". 4 files have
     unknown license. Detailed output of licensecheck in
     /home/asinha/dump/fedora-reviews/2090707-cr-marcstevens-
     snippets/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cr-
     marcstevens-snippets-base64-devel , cr-marcstevens-snippets-
     concurrent_unordered_map-devel , cr-marcstevens-snippets-
     cpuperformance-devel , cr-marcstevens-snippets-parallel_algorithms-
     devel , cr-marcstevens-snippets-program_options-devel , cr-
     marcstevens-snippets-progress_display-devel , cr-marcstevens-snippets-
     string_algo-devel , cr-marcstevens-snippets-thread_pool-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking:
cr-marcstevens-snippets-base64-devel-0^20210722gite01ae88-0.1.fc40.noarch.rpm
         
cr-marcstevens-snippets-concurrent_unordered_map-devel-0^20210722gite01ae88-0.1.fc40.noarch.rpm
         
cr-marcstevens-snippets-cpuperformance-devel-0^20210722gite01ae88-0.1.fc40.noarch.rpm
         
cr-marcstevens-snippets-parallel_algorithms-devel-0^20210722gite01ae88-0.1.fc40.noarch.rpm
         
cr-marcstevens-snippets-program_options-devel-0^20210722gite01ae88-0.1.fc40.noarch.rpm
         
cr-marcstevens-snippets-progress_display-devel-0^20210722gite01ae88-0.1.fc40.noarch.rpm
         
cr-marcstevens-snippets-string_algo-devel-0^20210722gite01ae88-0.1.fc40.noarch.rpm
         
cr-marcstevens-snippets-thread_pool-devel-0^20210722gite01ae88-0.1.fc40.noarch.rpm
          cr-marcstevens-snippets-0^20210722gite01ae88-0.1.fc40.src.rpm
===========================================================================
rpmlint session starts
==========================================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpl3nrg412')]
checks: 31, packages: 9

cr-marcstevens-snippets-base64-devel.noarch: W: no-documentation
cr-marcstevens-snippets-concurrent_unordered_map-devel.noarch: W:
no-documentation
cr-marcstevens-snippets-cpuperformance-devel.noarch: W: no-documentation
cr-marcstevens-snippets-parallel_algorithms-devel.noarch: W: no-documentation
cr-marcstevens-snippets-program_options-devel.noarch: W: no-documentation
cr-marcstevens-snippets-progress_display-devel.noarch: W: no-documentation
cr-marcstevens-snippets-string_algo-devel.noarch: W: no-documentation
cr-marcstevens-snippets-thread_pool-devel.noarch: W: no-documentation
============================================ 9 packages and 0 specfiles
checked; 0 errors, 8 warnings, 0 badness; has taken 0.4 s
===========================================




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 8

cr-marcstevens-snippets-cpuperformance-devel.noarch: W: no-documentation
cr-marcstevens-snippets-progress_display-devel.noarch: W: no-documentation
cr-marcstevens-snippets-string_algo-devel.noarch: W: no-documentation
cr-marcstevens-snippets-parallel_algorithms-devel.noarch: W: no-documentation
cr-marcstevens-snippets-thread_pool-devel.noarch: W: no-documentation
cr-marcstevens-snippets-program_options-devel.noarch: W: no-documentation
cr-marcstevens-snippets-base64-devel.noarch: W: no-documentation
cr-marcstevens-snippets-concurrent_unordered_map-devel.noarch: W:
no-documentation
 8 packages and 0 specfiles checked; 0 errors, 8 warnings, 0 badness; has taken
0.0 s 



Source checksums
----------------
https://www.boost.org/LICENSE_1_0.txt :
  CHECKSUM(SHA256) this package     :
c9bff75738922193e67fa726fa225535870d2aa1059f91452c411736284ad566
  CHECKSUM(SHA256) upstream package :
c9bff75738922193e67fa726fa225535870d2aa1059f91452c411736284ad566
https://github.com/cr-marcstevens/snippets/archive/e01ae885cdbef3af265341110a434f6fa7b8e8ac/snippets-e01ae885cdbef3af265341110a434f6fa7b8e8ac.tar.gz
:
  CHECKSUM(SHA256) this package     :
c19270666a42fc6192f3207d7869d1461d2579f3f83e8b7115d72be923f57571
  CHECKSUM(SHA256) upstream package :
c19270666a42fc6192f3207d7869d1461d2579f3f83e8b7115d72be923f57571


Requires
--------
cr-marcstevens-snippets-base64-devel (rpmlib, GLIBC filtered):

cr-marcstevens-snippets-concurrent_unordered_map-devel (rpmlib, GLIBC
filtered):

cr-marcstevens-snippets-cpuperformance-devel (rpmlib, GLIBC filtered):

cr-marcstevens-snippets-parallel_algorithms-devel (rpmlib, GLIBC filtered):

cr-marcstevens-snippets-program_options-devel (rpmlib, GLIBC filtered):

cr-marcstevens-snippets-progress_display-devel (rpmlib, GLIBC filtered):

cr-marcstevens-snippets-string_algo-devel (rpmlib, GLIBC filtered):

cr-marcstevens-snippets-thread_pool-devel (rpmlib, GLIBC filtered):



Provides
--------
cr-marcstevens-snippets-base64-devel:
    cr-marcstevens-snippets-base64-devel
    cr-marcstevens-snippets-base64-static

cr-marcstevens-snippets-concurrent_unordered_map-devel:
    cr-marcstevens-snippets-concurrent_unordered_map-devel
    cr-marcstevens-snippets-concurrent_unordered_map-static

cr-marcstevens-snippets-cpuperformance-devel:
    cr-marcstevens-snippets-cpuperformance-devel
    cr-marcstevens-snippets-cpuperformance-static

cr-marcstevens-snippets-parallel_algorithms-devel:
    cr-marcstevens-snippets-parallel_algorithms-devel
    cr-marcstevens-snippets-parallel_algorithms-static

cr-marcstevens-snippets-program_options-devel:
    cr-marcstevens-snippets-program_options-devel
    cr-marcstevens-snippets-program_options-static

cr-marcstevens-snippets-progress_display-devel:
    cr-marcstevens-snippets-progress_display-devel
    cr-marcstevens-snippets-progress_display-static

cr-marcstevens-snippets-string_algo-devel:
    cr-marcstevens-snippets-string_algo-devel
    cr-marcstevens-snippets-string_algo-static

cr-marcstevens-snippets-thread_pool-devel:
    cr-marcstevens-snippets-thread_pool-devel
    cr-marcstevens-snippets-thread_pool-static



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2090707
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Python, Haskell, SugarActivity, Ocaml, R, Perl, PHP, fonts,
Java
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH



Kalvin, are you looking to get sponsored as a package maintainer and so doing
informal reviews? I think you ran fedora-review on the package, but you must
also go through all the unmarked points manually and address them. See my
review here, for example ^.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2090707

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202090707%23c4
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux