[Bug 2231207] Review Request: golang-github-google-32 - Go library for accessing the GitHub v3 API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2231207

Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
             Status|ASSIGNED                    |POST
           Assignee|mhayden@xxxxxxxxxx          |zebob.m@xxxxxxxxx
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #1 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> ---
SAME ISSUE:


Are you sure you need this package? We have golang-github-google-go-github at
version 53 in Fedora:

# Generated by go2rpm 1.9.0
# Needs network
%bcond_with check
%global debug_package %{nil}

# https://github.com/google/go-github
%global goipath         github.com/google/go-github
Version:                53.1.0

%gometa

%global goname golang-github-google-go-github

%global goaltipaths     github.com/google/go-github/v53



What I do in most package is switch the import path so it depends on the Fedora
Package:


sed -i 's|github.com/google/go-github/v35|github.com/google/go-github|' $(find
. -iname '*.go' -type f)



****Usually it works, so unless you need that very specific version, I'd
recommend against packaging it.****


Same review:

Clean up this every time you use go2rpm:

%global golicenses      LICENSE github/licenses.go github/licenses_test.go
%global godocs          example AUTHORS CONTRIBUTING.md README.md example\\\
                        scrape/README.md
->

%global golicenses      LICENSE
%global godocs          example AUTHORS CONTRIBUTING.md README.md


%license LICENSE github/licenses.go github/licenses_test.go
%doc example AUTHORS CONTRIBUTING.md README.md example scrape/README.md

->

%license LICENSE
%doc example AUTHORS CONTRIBUTING.md README.md



-> your SPEC name is incorrect.

So I would recommend using a goname to fix the name

%global goname golang-github-google-go-github-32

Otherwise rename the SPEC to follow the computed goname

-> Don't build the binary:

%build
for cmd in github update-urls; do
  %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
done

If you need the binaries built, do it in the package we already have which is
the latest version.


- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Package approved.

Please:
 - add commit rights to go-sig after requesting the repo
 - add the package to Koschei in the go-sig group on all branches you are
building
 - add the package to release-monitoring.org even if it does not release
version


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2231207

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202231207%23c1
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux